Bug: Fix for Query with Special Characters Failing Against Overseer #134
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
The-Running-Dev
commented
Feb 6, 2024
The-Running-Dev
commented
- Modified Overseerr call to encode the query parameter
- Added new util function, url-encode-illegal-characters (sources from hato.middleware) but with URL encoding all non alpha-numeric characters.
- Modified Overseerr call to encode the query parameter - Added new util function, url-encode-illegal-characters (sources from hato.middleware) but with URL encoding all non alpha-numeric characters.
- Re-ordered string replacement to fix double encoding
|
This is a good solution for now - but I think I need to figure out why hato wasn't URL-encoding everything. |
|
You know this issue...you commented on the Overseer repo...sct/overseerr#2010 Look at my last comment here. https://www.reddit.com/r/Clojure/comments/1akfy0a/comment/kp9v1eo/?context=3 |
And I had promptly forgotten about it. |
truecharts-admin
added a commit
to truecharts/charts
that referenced
this pull request
Feb 12, 2024
…6.3@426517f by renovate (#18133) This PR contains the following updates: | Package | Update | Change | |---|---|---| | [ghcr.io/kiranshila/doplarr](https://togithub.com/kiranshila/Doplarr) | patch | `v3.6.2` -> `v3.6.3` | --- > [!WARNING] > Some dependencies could not be looked up. Check the Dependency Dashboard for more information. --- ### Release Notes <details> <summary>kiranshila/Doplarr (ghcr.io/kiranshila/doplarr)</summary> ### [`v3.6.3`](https://togithub.com/kiranshila/Doplarr/releases/tag/v3.6.3) [Compare Source](https://togithub.com/kiranshila/Doplarr/compare/v3.6.2...v3.6.3) #### What's Changed - Add extra detail to Discord configuration instructions by [@​jconnop](https://togithub.com/jconnop) in [kiranshila/Doplarr#109 - Bug: Fix for Query with Special Characters Failing Against Overseer by [@​The-Running-Dev](https://togithub.com/The-Running-Dev) in [kiranshila/Doplarr#134 #### New Contributors - [@​jconnop](https://togithub.com/jconnop) made their first contribution in [kiranshila/Doplarr#109 - [@​The-Running-Dev](https://togithub.com/The-Running-Dev) made their first contribution in [kiranshila/Doplarr#134 **Full Changelog**: kiranshila/Doplarr@v3.6.2...v3.6.3 </details> --- ### Configuration 📅 **Schedule**: Branch creation - "before 10pm on monday" in timezone Europe/Amsterdam, Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://togithub.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4xODMuMCIsInVwZGF0ZWRJblZlciI6IjM3LjE4My4wIiwidGFyZ2V0QnJhbmNoIjoibWFzdGVyIn0=-->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.