kirby 3 rewrite #4
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
but did not do component to cache pages Signed-off-by: Bruno Meilick <b@bnomei.com>
|
oh yes. i do not actually want to commit to |
https://github.com/k-next/kirby/blob/e3899ba66cd26740a5ff38a8d224e7de0aadc344/src/Cache/FileCache.php Signed-off-by: Bruno Meilick <b@bnomei.com>
Signed-off-by: Bruno Meilick <b@bnomei.com>
|
rewrote code to new cache which makes this plugin kind of useless but might be nice if porting k2 pages to k3 – kind of a wrapper. https://www.notion.so/Cache-Concept-3b7ba5af6ddf4863b1344fc7b433a729 |
|
did my own version with minor changes i case you are interested: |
|
@bnomei If it's good enough (which means works great and is simple enough), you can take over this feature with your plugin. When Kirby 3 is released I'll close mine. |
|
its dead simple like yours before. i just added the option to force updating the cache, which i needed once or twice before, and moved from seconds to minutes (like kirby cache does now) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
but did not do component to cache pages.
docs/kirby-3-version.md show basic test.
Signed-off-by: Bruno Meilick b@bnomei.com