-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BUG] Title in page not fitting on one line when actions are present #1095
Comments
is this also happening when u have a button with only an icon @MortenGregersen ? :) |
Yes |
Jeah i see that. Long words and the page-title don't go along very well... :( But we are also aware of this and working on other kinds of headers. This doesn't mean that this shouldn't be fixed though :) |
This issue has been automatically marked as stale because of no recent activity. It will be closed in 10 weeks if no further activity occurs. Thank you for your contributions. |
Suggestion for solutionA solution must take into consideration what should happen when things do not fit. Expect the worst: Longer words, larger font sizes (which are controlled by the end-user), small device/viewport sizes etc. Suggestion
|
Consider migrating to new header where this is fixed: https://cookbook.kirby.design/#/home/showcase/header |
Describe the bug
When a non-breakable title is used in a page with
titleMaxLines
set to 1 and actions present, the title isn't fitting/scaled down on small screen sizes like the iPhone 5s/SE (5-inch).In "Investment" in DRB we have a long non-breakable title and a wide button as action, so it isn't looking great on the small screens.
To Reproduce
Steps to reproduce the behavior:
Create a page like the following. The easiest is to use the
PageFitHeadingExampleComponent
in the Cookbook and change the title and add the actions.Kirby version
Expected behavior
I would expect the title to scale down
Screenshots
Please complete the following information:
Tasks:
closes #issueno
to the description) and ask @kirbydesign/kirby-guild for reviewThe text was updated successfully, but these errors were encountered: