Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Divider color on background #764

Merged
merged 2 commits into from Nov 12, 2019
Merged

Divider color on background #764

merged 2 commits into from Nov 12, 2019

Conversation

MortenGregersen
Copy link
Contributor

@MortenGregersen MortenGregersen commented Nov 11, 2019

When the divider was added to a modal or something else with background-color as background color, it would be invisible (also have background-color as color).

Now it will have background-color as color when in Card, unless the card has either white or light theme color. If not in card it will have medium as color.

jakobe
jakobe previously approved these changes Nov 12, 2019
src/kirby/components/divider/divider.component.scss Outdated Show resolved Hide resolved
Copy link
Collaborator

@jakobe jakobe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@jakobe jakobe merged commit bf62d3f into master Nov 12, 2019
@jakobe jakobe deleted the divider-color-on-modal branch November 12, 2019 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants