Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current behavior for ffmpeg settings is to set crf=0 and b:v 40M which I understand are mutually exclusive. They also have no effect for some hw accelerated options like videotoolbox. The approach taken is to set some sane defaults per encoder that will grow over time so must users can just press a button and have it 'work'. The settings are not set in stone at all and are not comprehensive at this stage.
The method Utils.load_encoder_defaults_yaml attempts to find this settings file but falls back to the existing encoder settings. If no settings around found it will also fall back to those same defaults, whether or not they work for the specified codec.
Keen to get your feedback to see if this is a direction worth taking. A few things im thinking of: