Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Overriding device's name with device's ID from known_devices.yaml #4

Closed
kirichkov opened this issue Apr 1, 2017 · 3 comments
Closed

Comments

@kirichkov
Copy link
Owner

https://github.com/kamaradclimber/home_assistant-ble/blob/master/lib/home_assistant/ble.rb#L49

I see that you override the device's friendly name on purpose. Can you explain to me what's your reasoning behind it? For me that was unexpected when the device's name changed to it's dev_id.

@kirichkov
Copy link
Owner Author

I think I figured it out. Instead of using /api/services/device_tracker/see you are directly changing the state via /api/states/. I am not sure, however, that this will trigger an event for the state change, i.e. - state-based automations might not be running.

I think it's better to use the device_tracker API, instead of directly updating the state of the device.

@kamaradclimber
Copy link
Collaborator

kamaradclimber commented Apr 2, 2017 via email

@kamaradclimber
Copy link
Collaborator

fixed by #5

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants