Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tweak the implementation of FIT_TO_ICON layout manager #341

Closed
kirill-grouchnikov opened this issue Jun 4, 2021 · 0 comments
Closed

Tweak the implementation of FIT_TO_ICON layout manager #341

kirill-grouchnikov opened this issue Jun 4, 2021 · 0 comments
Assignees
@kirill-grouchnikov
Labels
4.0 - Feldspar Release 4.0 - 2021.H1 Breaking change Marking changes that break backwards compatibility

Comments

@kirill-grouchnikov
Copy link
Owner

  1. There's a lot of code copy-pasted from the base class. The only difference is in getting the icon width / height
  2. The layout manager is CommandButtonLayoutManagerCustom - rename to CommandButtonLayoutManagerFitToIcon
@kirill-grouchnikov kirill-grouchnikov added Breaking change Marking changes that break backwards compatibility 4.0 - Feldspar Release 4.0 - 2021.H1 labels Jun 4, 2021
@kirill-grouchnikov kirill-grouchnikov self-assigned this Jun 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kirill-grouchnikov kirill-grouchnikov

Labels
4.0 - Feldspar Release 4.0 - 2021.H1 Breaking change Marking changes that break backwards compatibility
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@kirill-grouchnikov