Client-side store memoization not working with hot module reloading

[timotgl]

When navigating to a different page in our app we see the following warning:

We believe that this is caused by using both withRedux and connect. The store is memoized in the module scope here but then HMR reloads the module, which creates another store instance:

[HMR] Updated modules:
[HMR]  - ./~/next-redux-wrapper/src/index.js
...

We initially thought that this might be related to using a _document.js template with next.js, especially after seeing this comment, but removing _document.js didn't solve our issue.

[kirill-konshin]

Good catch! Thanks. I will fix it in the next few days.

[neogermi]

I just stumbled over this. Is there any workaround for this that we could apply fast?

[timotgl]

@neogermi as a quick and dirty hack you can fork this library and attach (and restore) the store instance to the window object in the memoization function.

[kirill-konshin]

I suspect that window hack will be the default behavior, I suggest to name the property like __NEXT_REDUX_STORE__ or something similar... Don't hesitate to send a PR :)

The lib itself should not be hot-reloaded, because it does not change so referentially it should always be one object. Anyway, window fix should be just fine.

I have pushed a quick fix for you guys, you can install master branch and use it right away.

[kirill-konshin]

Fixed in 1.1.3

[neogermi]

Great thank you! Currently, 1.1.3 is not available through npm. When do you plan to publish it?

[kirill-konshin]

Oops, something went wrong with NPM publish after Travis CI, I will fix that tomorrow first thing in the morning.

[kirill-konshin]

Published.

[neogermi]

great thank you for the fast response!