Fix #165 #176
Merged
Fix #165 #176
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for approaching this; it has been on my to do list for quite a while now! LGTM! There are still some things I would like to improve though – would you mind giving me write access to your |
|
You can make a PR with target I've commented few lines that will be removed in future, as with new addition they became obsolete. |
* use strict type checking * fix redux-related type annotations in demo * Use single jest config * Thanks to @jest-environment doc annotations; fixes coverage reports * add ReduxWrappedAppProps interface * Rename ReduxWrappedAppProps to ReduxWrapperAppProps * Remove legacy `AppProps` and `OriginalAppProps` alias * Base `ReduxWrapperAppProps` directly on Next.js `AppProps` * Remove deprecated Container from example _app
kirill-konshin
pushed a commit
that referenced
this pull request
Feb 11, 2020
* Add motivation section (#170) * Add TypeScript examples (#176, #177) * Make installation code blocks expandable * Migrate connected Page components to functional components * Group tips and examples in a Tips and Tricks section * Some grammar & style improvements * Remove outdated typings reference in Resources section
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TypeScript NextPageContext augmentation
@bjoluc take a look.