Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create better comments #6

Merged
merged 2 commits into from
Jan 19, 2021
Merged

Create better comments #6

merged 2 commits into from
Jan 19, 2021

Conversation

kirillperesh
Copy link
Owner

No description provided.

@github-learning-lab
Copy link

Improving the issue comment

💡Did you know that GitHub Script also grants you access to a full Node.js environment?

Although we wouldn't recommend using GitHub Script to write the logic for complex actions, there are use cases where you may want to leverage using a little more than just the octokit/rest.js API.

One such use case is our issue comment. Right now it is pretty hard coded the way it is making it less than ideal. What if we wanted to display our contribution guide every time an issue was opened?

Instead of writing the guide directly into our workflow, we can use the Node.js File System module to read a file and use it as the body of our issue comment.

If we want access to the files within our repository, we need to make sure we include the actions/checkout action in our workflow as the first step.

@github-learning-lab
Copy link

Use the FS module to use a templated comment

We will make the following changes to the current workflow file:

  • Add the actions/checkout action so we can read the templated response file located at .github/ISSUE_RESPONSES/comment.md
  • Add JavaScript to use the Node.js File System module to place the contents of our templated response as the body of the issue comment.

⌨️ Activity: Add newly opened issue to project board

  1. Edit the current workflow to have the following contents:

    name: Learning GitHub Script
    
    on:
      issues:
        types: [opened]
    
    jobs:
      comment:
        runs-on: ubuntu-latest
        steps:
          - name: Checkout repo
            uses: actions/checkout@v2
    
          - name: Comment on new issue
            uses: actions/github-script@0.8.0
            with:
              github-token: ${{secrets.GITHUB_TOKEN}}
              script: |
                 const fs = require('fs')
                 const issueBody = fs.readFileSync(".github/ISSUE_RESPONSES/comment.md", "utf8")
                 github.issues.createComment({
                 issue_number: context.issue.number,
                 owner: context.repo.owner,
                 repo: context.repo.repo,
                 body: issueBody
                 })
    
          - name: Add issue to project board
            if: contains(github.event.issue.labels.*.name, 'bug')
            uses: actions/github-script@0.8.0
            with:
              github-token: ${{secrets.GITHUB_TOKEN}}
              script: |
                github.projects.createCard({
                column_id: 12524419,
                content_id: context.payload.issue.id,
                content_type: "Issue"
                });
    
  2. Commit the workflow changes to this branch.


I am waiting for you to commit the desired changes to this branch before moving on.

I'll respond once you've committed the changes to this branch

Copy link

@github-learning-lab github-learning-lab bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Time to see the magic in action!

@kirillperesh, All of the necessary changes have been made, and our workflow now contains enough information to be quite awesome!

⌨️ Activity: Merge the workflow

When you are ready, merge this pull request.


I am waiting for you to merge this pull request before moving on.

Once you have merged this pull request I will open a new issue so we can see this workflow in action!

Trouble merging?Try refreshing the page!

@kirillperesh kirillperesh merged commit 62ba7b2 into main Jan 19, 2021
@github-learning-lab
Copy link

A new issue has been opened

I have created a new issue where we will continue this lesson. Click the link to meet me over there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant