Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Depend on railties and not on rails gem #43

Merged
merged 1 commit into from
Oct 11, 2023

Conversation

deepj
Copy link
Contributor

@deepj deepj commented Sep 8, 2023

Hello,
in my Rails application, I don't use the whole Rails default stack - For example I don't need to use any ActionText or ActionMailbox gem.

Unfortunately, depending onrails gem enforces non-needed gem with this gem. This gem for working depends on a small fraction of Rails stack and can work only three railties, actioncable and listen gems. It's better to require only these gem as necessary dependencies.

I created a similar PR (rails/jsbundling-rails#13) to this issue in jsbundling-rails two years ago (accepted).

E.g. tailwindcss-rails or cssbundling-rails depends on railties gem as well

@kirillplatonov
Copy link
Owner

@deepj great idea, thank you!

@kirillplatonov kirillplatonov merged commit e3c8ce1 into kirillplatonov:main Oct 11, 2023
@deepj deepj deleted the railties branch October 11, 2023 20:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants