Skip to content

Commit

Permalink
refactor: migrate off from set-output (#297)
Browse files Browse the repository at this point in the history
## 馃摐 Description

Migrate off from `set-output`.

## 馃挕 Motivation and Context

This command is deprecated and will be disabled in near future, so it's
better to migrate to the variant that will not produce this warning.

## 馃摙 Changelog

### CI
- used modern syntax instead of `::set-output`;
- synchronized code between `e2e` actions;

## 馃 How Has This Been Tested?

Tested via GH actions.

## 馃摳 Screenshots (if appropriate):

<img width="1351" alt="image"
src="https://github.com/kirillzyusko/react-native-keyboard-controller/assets/22820318/1e801cf6-0ca4-4aff-9da8-0a7f41f0e2dd">

## 馃摑 Checklist

- [x] CI successfully passed
  • Loading branch information
kirillzyusko committed Dec 15, 2023
1 parent db5a741 commit 5492356
Show file tree
Hide file tree
Showing 6 changed files with 19 additions and 7 deletions.
7 changes: 4 additions & 3 deletions .github/workflows/android-e2e-test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ jobs:
java-version: '11'
- name: Get yarn cache directory path
id: yarn-cache-dir-path
run: echo "::set-output name=dir::$(yarn cache dir)"
run: echo "dir=$(yarn cache dir)" >> $GITHUB_OUTPUT
- name: Restore node_modules from cache
uses: actions/cache@v3
id: yarn-cache
Expand All @@ -53,8 +53,9 @@ jobs:
${{ runner.os }}-yarn-
- name: Install root dependencies
run: yarn install
- name: Install node_modules for example/
run: yarn install --frozen-lockfile --cwd example
- name: Install example project dependencies
working-directory: ${{ env.WORKING_DIRECTORY }}
run: yarn
- name: Install e2e dependencies
run: yarn install --cwd e2e
- name: Restore Gradle cache
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/build-android-fabric.yml
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ jobs:

- name: Get yarn cache directory path
id: fabric-yarn-cache-dir-path
run: echo "::set-output name=dir::$(yarn cache dir)"
run: echo "dir=$(yarn cache dir)" >> $GITHUB_OUTPUT
- name: Restore node_modules from cache
uses: actions/cache@v3
id: yarn-cache
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/build-android.yml
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ jobs:

- name: Get yarn cache directory path
id: yarn-cache-dir-path
run: echo "::set-output name=dir::$(yarn cache dir)"
run: echo "dir=$(yarn cache dir)" >> $GITHUB_OUTPUT
- name: Restore node_modules from cache
uses: actions/cache@v3
id: yarn-cache
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/build-ios-fabric.yml
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ jobs:

- name: Get yarn cache directory path
id: fabric-yarn-cache-dir-path
run: echo "::set-output name=dir::$(yarn cache dir)"
run: echo "dir=$(yarn cache dir)" >> $GITHUB_OUTPUT
- name: Restore node_modules from cache
uses: actions/cache@v3
id: yarn-cache
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/build-ios.yml
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ jobs:

- name: Get yarn cache directory path
id: yarn-cache-dir-path
run: echo "::set-output name=dir::$(yarn cache dir)"
run: echo "dir=$(yarn cache dir)" >> $GITHUB_OUTPUT
- name: Restore node_modules from cache
uses: actions/cache@v3
id: yarn-cache
Expand Down
11 changes: 11 additions & 0 deletions .github/workflows/ios-e2e-test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,17 @@ jobs:
run: xcodebuild -version
- name: Install AppleSimulatorUtils
run: brew tap wix/brew && brew install applesimutils
- name: Get yarn cache directory path
id: yarn-cache-dir-path
run: echo "dir=$(yarn cache dir)" >> $GITHUB_OUTPUT
- name: Restore node_modules from cache
uses: actions/cache@v3
id: yarn-cache
with:
path: ${{ steps.yarn-cache-dir-path.outputs.dir }}
key: ${{ runner.os }}-yarn-${{ hashFiles('**/yarn.lock') }}
restore-keys: |
${{ runner.os }}-yarn-
- name: Install root dependencies
run: yarn install
- name: Install example project dependencies
Expand Down

0 comments on commit 5492356

Please sign in to comment.