-
-
Notifications
You must be signed in to change notification settings - Fork 55
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
feat:
KeyboardToolbar
callbacks (#419)
## 馃摐 Description Added `onDoneCallback`/`onNextCallback`/`onPrevCallback` functions to `KeyboardToolbar`. ## 馃挕 Motivation and Context It's often needed to customize behavior when buttons are pressed, for example do a haptic feedback or even play a sound. Before this PR it wasn't possible to add an action that will be called whenever user presses a particular button along with the default action. But in this PR I added it. Initially I wanted to provide `onNextPress` functions that would redefine an entire handler. But in this case users will have to go into source code and understand how `KeyboardToolbar` works under the hood. Even though it's not difficult it's better to keep such things internally (and in most cases users will rely on defult behavior - in case if we need to re-define a behavior I'll add new functions later). ## 馃摙 Changelog ### Docs - added docs about new `onDoneCallback`/`onNextCallback`/`onPrevCallback` callbacks; ### JS - added `onDoneCallback`/`onNextCallback`/`onPrevCallback`; ## 馃 How Has This Been Tested? Tested on Pixel 7 Pro (android 14) and iPhone 11 (iOS 17.4). ## 馃摳 Screenshots (if appropriate): There is no way to test haptic visually 馃榾 ## 馃摑 Checklist - [x] CI successfully passed - [x] I added new mocks and corresponding unit-tests if library API was changed
- Loading branch information
1 parent
64b2e21
commit 7d2ccb5
Showing
10 changed files
with
151 additions
and
7 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters