Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
fix: use
install_modules_dependencies
to fix compilation issues on …
…RN 0.73 with Fabric (#308) ## 📜 Description Started to use `install_modules_dependencies` in `.podspec`. ## 💡 Motivation and Context It's vital to use `install_modules_dependencies` because it simplifies integration process (this function is shipped in RN, so RN team cares about internal deps that could be provided to the project). So it means that we don't need to specify it manually anymore and instead we can rely on the implementation provided by the package. However we need to keep in mind, that this function is available only from RN 0.71, so if we support RN < 0.71 we need to have fallback code. The other aspect that was discovered during the implementation is the fact that this function was broken on RN 0.72 + Swift + New Arch combination, but with latest RN release it's not broken anymore (that's the reason why I updated a RN dependency in this PR - to verify that it actually works as expected). Closes #371 ## 📢 Changelog <!-- High level overview of important changes --> <!-- For example: fixed status bar manipulation; added new types declarations; --> <!-- If your changes don't affect one of platform/language below - then remove this platform/language --> ### JS - updated RN to 0.72.11 ### iOS - modified `.podspec` file to use `install_modules_dependencies` function. ## 🤔 How Has This Been Tested? Tested manually in reproduction example + via CI. ## 📝 Checklist - [x] CI successfully passed
- Loading branch information