fix: restore more tests

kirillzyusko · May 10, 2024 · fd7a545 · fd7a545
1 parent 21d11f0
commit fd7a545
Show file tree

Hide file tree

Showing 3 changed files with 13 additions and 15 deletions.
diff --git a/e2e/kit/003-input-handlers.e2e.ts b/e2e/kit/003-input-handlers.e2e.ts
@@ -20,22 +20,20 @@ describe("input handlers functionality", () => {
     await waitForElementById("masked_input");
     await waitAndTap("masked_input");
     // make sure keyboard is shown
-    await delay(5000);
+    await delay(500);
     await waitAndType("masked_input", "1234567890");
     await expect(element(by.id("formatted_text"))).toHaveText(
       "Formatted: +1 (123) 456 78 90",
     );
     await expect(element(by.id("extracted_text"))).toHaveText(
       "Extracted: 1234567890",
     );
-    /*await expect(element(by.id("worklet_text"))).toHaveText(
+    await expect(element(by.id("worklet_text"))).toHaveText(
       "Worklet: +1 (123) 456 78 90",
-    );*/
-    await delay(10000);
+    );
   });
 
   it("should fire `onSelectionChange` with expected values", async () => {
-    await delay(10000);
     /*await waitFor(element(by.id("selection_text_start_end")))
       .toHaveText("start: 18, end: 18")
       .withTimeout(DEFAULT_TIMEOUT);
@@ -49,9 +47,9 @@ describe("input handlers functionality", () => {
     await waitFor(element(by.id("formatted_text")))
       .toHaveText("Formatted: QWERTY\nqwerty")
       .withTimeout(DEFAULT_TIMEOUT);
-    /*await waitFor(element(by.id("worklet_text")))
+    await waitFor(element(by.id("worklet_text")))
       .toHaveText("Worklet: QWERTY\nqwerty")
-      .withTimeout(DEFAULT_TIMEOUT);*/
+      .withTimeout(DEFAULT_TIMEOUT);
     await waitFor(element(by.id("selection_text_start_end")))
       .toHaveText("start: 13, end: 13")
       .withTimeout(DEFAULT_TIMEOUT);
@@ -65,9 +63,9 @@ describe("input handlers functionality", () => {
     await waitFor(element(by.id("formatted_text")))
       .toHaveText("Formatted: QWERTY")
       .withTimeout(DEFAULT_TIMEOUT);
-    /*await waitFor(element(by.id("worklet_text")))
+    await waitFor(element(by.id("worklet_text")))
       .toHaveText("Worklet: QWERTY")
-      .withTimeout(DEFAULT_TIMEOUT);*/
+      .withTimeout(DEFAULT_TIMEOUT);
     await waitFor(element(by.id("selection_text_start_end")))
       .toHaveText("start: 6, end: 6")
       .withTimeout(DEFAULT_TIMEOUT);
@@ -80,9 +78,9 @@ describe("input handlers functionality", () => {
     await waitFor(element(by.id("formatted_text")))
       .toHaveText("Formatted: QWERT")
       .withTimeout(DEFAULT_TIMEOUT);
-    /*await waitFor(element(by.id("worklet_text")))
+    await waitFor(element(by.id("worklet_text")))
       .toHaveText("Worklet: QWERT")
-      .withTimeout(DEFAULT_TIMEOUT);*/
+      .withTimeout(DEFAULT_TIMEOUT);
     await waitFor(element(by.id("selection_text_start_end")))
       .toHaveText("start: 5, end: 5")
       .withTimeout(DEFAULT_TIMEOUT);

diff --git a/e2e/kit/assets/ios/iPhone 15 Pro/InputHandlersKeyboardIsShown.png b/e2e/kit/assets/ios/iPhone 15 Pro/InputHandlersKeyboardIsShown.png
diff --git a/ios/delegates/KCTextInputCompositeDelegate.swift b/ios/delegates/KCTextInputCompositeDelegate.swift
@@ -82,13 +82,13 @@ class KCTextInputCompositeDelegate: NSObject, UITextViewDelegate, UITextFieldDel
     updateSelectionPosition(textInput: textView)
   }
 
-  /*func textViewDidChange(_ textView: UITextView) {
+  func textViewDidChange(_ textView: UITextView) {
     defer {
       self.onTextChange(textView.text)
     }
 
     textViewDelegate?.textViewDidChange?(textView)
-  }*/
+  }
 
   // MARK: UITextFieldDelegate
 
@@ -97,7 +97,7 @@ class KCTextInputCompositeDelegate: NSObject, UITextViewDelegate, UITextFieldDel
     updateSelectionPosition(textInput: textField)
   }
 
-  /*func textField(
+  func textField(
     _ textField: UITextField,
     shouldChangeCharactersIn range: NSRange,
     replacementString string: String
@@ -107,7 +107,7 @@ class KCTextInputCompositeDelegate: NSObject, UITextViewDelegate, UITextFieldDel
     }
 
     return textFieldDelegate?.textField?(textField, shouldChangeCharactersIn: range, replacementString: string) ?? true
-  }*/
+  }
 
   // MARK: call forwarding