Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KeyboardToolbar component with different text input types #374

Closed
IvanIhnatsiuk opened this issue Mar 4, 2024 · 0 comments · Fixed by #376
Closed

KeyboardToolbar component with different text input types #374

IvanIhnatsiuk opened this issue Mar 4, 2024 · 0 comments · Fixed by #376
Assignees
Labels
🐛 bug Something isn't working KeyboardStickyView 🩹 Anything related to KeyboardStickyView component KeyboardToolbar Anything related to KeyboardToolbar component

Comments

@IvanIhnatsiuk
Copy link
Contributor

IvanIhnatsiuk commented Mar 4, 2024

Describe the bug

Hello @kirillzyusko . Thank you for your library it's really great and powerful.

I wanted to add KeyboardToolbar component in my current app and I found several issues.

  1. When I switch between the numeric and text keyboard, it changes the KeyboardToolbar offset with animation, but I think this behaviour should be the same as the native keyboard (without animation).
  2. The second problem is that keyboard pressable elements have a different animation when clicked on:
    different color of ripple effect.
    ripple effect of keyboard elements is faster.

Repo for reproducing

I think that you can reproduce this issue in your example app in keyboard toolbar example.

To Reproduce
Steps to reproduce the behavior:

  1. Focus on number text input
  2. Change focus via toolbar to another non number text input
  3. See that KeyboardToolbar changes with animation

Expected behavior

Keyboard toolbar should change his offset like native keyboard toolbar.

Screenshots

Screen.Recording.2024-03-04.at.15.08.02.mov
Screen.Recording.2024-03-04.at.15.35.49.mov
  • Desktop OS: [e.g. Windows 10, MacOS 10.15.5]
  • Device: [e.g. iPhone8]
  • OS: [e.g. iOS 10.0]
  • RN version: [e.g. 0.68.2]
  • RN architecture: [e.g. old/new or paper/fabric]
  • JS engine: [e.g. JSC, Hermes, v8]
  • Library version: [e.g. 1.2.0]

Additional context

N/A

@kirillzyusko kirillzyusko added the 🐛 bug Something isn't working label Mar 4, 2024
@kirillzyusko kirillzyusko added KeyboardStickyView 🩹 Anything related to KeyboardStickyView component KeyboardToolbar Anything related to KeyboardToolbar component labels May 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 bug Something isn't working KeyboardStickyView 🩹 Anything related to KeyboardStickyView component KeyboardToolbar Anything related to KeyboardToolbar component
Projects
None yet
2 participants