feat: change keyboard toolbar offset instantly when keyboard is open #375
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@IvanIhnatsiuk do you think it would be better to merge this PR instead? #376 |
|
Closed in favor of #376 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
馃摐 Description
I've added logic to handle the case where the keyboard is open and the user focuses on another text input with a different input type.
The toolbar used to change animatedly but it didn't look good, now it changes just like the native toolbar.
馃挕 Motivation and Context
Closes #374
馃摙 Changelog
Changed logic in KeyboardStickyView component to handle case when keyboard is opened and keyboard size changed.
馃 How Has This Been Tested?
iPhone 15 pro
Pixel 3a emulator
Android 9 emulator
馃摳 Screenshots (if appropriate):
Pixel 3a emulator
Screen.Recording.2024-03-05.at.19.28.41.mov
Android 9
Screen.Recording.2024-03-05.at.19.41.00.mov
iPhone 15 pro
Simulator.Screen.Recording.-.iPhone.15.Pro.-.2024-03-05.at.19.28.29.mp4
馃摑 Checklist