-
-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: enabled #227
Merged
Merged
feat: enabled #227
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Closed
Closed
1252c72
to
1b92935
Compare
📊 Package size report
|
0577e89
to
fab7cdd
Compare
e7592d9
to
2fffc98
Compare
yayvery
suggested changes
Sep 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📜 Description
Added
useKeyboardController
hook that returnssetEnabled
+enabled
(which allows to disable and enable module on demand).💡 Motivation and Context
Fixes #233 #198 #241
📢 Changelog
JS
useKeyboardController
hook that gives an access tosetEnabled
method andenabled
variable (that indicates current state);enabled
property to specs;enabled
property via state (from react) and passing methods via context to change the value of this variable;enabled
value.iOS
mount
/unmount
depends on the value that comes;updateProps
method and callmount
/unmount
depends on the value that comes;Android
edge-to-edge
when prop is set (before we did it inonAttachedToWindow
method);edge-to-edge
mode ifonAttachedToWindow
is called more than one time;statusBarTranslucent
props is set;rootView
to consume and propagate insets accordingly;setupWindowInsets
;Docs
useKeyboardController
hook;keyboard
andmodule
;🤔 How Has This Been Tested?
Tested on:
📸 Screenshots (if appropriate):
Screen.Recording.2023-09-11.at.13.21.05.mov
enabled-disabled-trimmed.mp4
📝 Checklist