Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: integrate typescript-eslint-plugin #252

Conversation

IvanIhnatsiuk
Copy link
Contributor

@IvanIhnatsiuk IvanIhnatsiuk commented Oct 4, 2023

馃摐 Description

added @typescript-eslint/eslint-plugin to support importing and exporting types with eslint to avoid adding some types file in the final build. Also, it would be useful to have a more strict eslint in the project 馃檪 .

馃挕 Motivation and Context

code base improvement

馃摙 Changelog

  • Created .eslintrc.cjs with eslint configuration.
  • Added @typescript-eslint/eslint-plugin, @typescript-eslint/parser and eslint-plugin-jest

馃 How Has This Been Tested?

Tested with the yarn lint command 馃檪 .

馃摑 Checklist

  • CI successfully passed

src/context.ts Outdated Show resolved Hide resolved
@kirillzyusko kirillzyusko changed the title integrate typescript-eslint-plugin refactor: integrate typescript-eslint-plugin Oct 4, 2023
@kirillzyusko kirillzyusko self-assigned this Oct 4, 2023
@kirillzyusko kirillzyusko added the refactor You changed the code but it didn't affect functionality label Oct 4, 2023
@IvanIhnatsiuk IvanIhnatsiuk force-pushed the feature-integrate-typescript-eslint-plugin branch from 2f2fdd4 to 9711183 Compare October 4, 2023 13:57
@kirillzyusko kirillzyusko merged commit 235fc9d into kirillzyusko:main Oct 4, 2023
7 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactor You changed the code but it didn't affect functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants