Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RNKC-045] - status bar management new API #30

Merged
merged 5 commits into from
Jun 9, 2022
Merged

Conversation

kirillzyusko
Copy link
Owner

@kirillzyusko kirillzyusko commented Jun 1, 2022

Description

Added new module, which manages StatusBar in compat mode (without deprecated methods).

Motivation and Context

It's needed, because old way with managing window flags is now deprecated. And if you have such code - it will break keyoard animations.

Fixes: #20

Changelog

JS

  • added monkey patch for RN status bar;

Android

  • added module for managing StatusBar in compat mode;

How Has This Been Tested?

Tested manually on:

  • API 25;
  • API 28;
  • API 32;

Checklist

  • CI successfully passed

@kirillzyusko kirillzyusko marked this pull request as ready for review June 9, 2022 18:35
@kirillzyusko kirillzyusko merged commit 684a110 into main Jun 9, 2022
@kirillzyusko kirillzyusko deleted the bugfix/status-bar branch June 9, 2022 18:35
@kirillzyusko kirillzyusko added the 🤖 android Android specific label Mar 14, 2023
@rikur
Copy link

rikur commented Feb 20, 2024

Wow, that was clever monkey-patching 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🤖 android Android specific
Projects
None yet
Development

Successfully merging this pull request may close these issues.

StatusBar manipulation causes frozen animation values
2 participants