fix: forward ref to KeyboardAwareScrollView
#345
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📜 Description
Right now it's impossible to assign
ref
onKeyboardAwareScrollView
and accessScrollView
methods. This PR fixes this problem.💡 Motivation and Context
It's important to have
ref
in many cases - so I think motivation why it's needed is pretty clear 😅The technical aspect is a little bit tricky, since internally we also use
ref
(from REA hook) and we need to propagate it from inside the component. To achieve this I addedonRef
callback that manages everything 😎 It uses single ref and derives a reanimated ref + assigns plainref
for typical RN usage.This PR has a lot of changes, but it's because of prettier. Main changes are
onRef
+forwardRef
component wrap.📢 Changelog
JS
forwardRef
onKeyboardAwareScrollView
;KeyboardAwareScrollView
for reanimated usage + assign it to forwarded ref;🤔 How Has This Been Tested?
Tested manually on Xiaomi Redmi Note 5 Pro.
📝 Checklist