fix: not detectable keyboard view on iOS #471
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
馃搳 Package size report
|
kirillzyusko
force-pushed
the
fix/keyboard-view-is-not-detectable
branch
from
9e09296
to
7053e1f
Compare
2 tasks
kirillzyusko
added a commit
that referenced
this pull request
Jun 14, 2024
## 馃摐 Description Ignore non visible keyboard in `KeyboardView.find()` method. ## 馃挕 Motivation and Context Sometimes we may have two keyboards:  And the current algorithm for a search returns an invalid keyboard (not a one that is actually shown on the screen):  or  But when actual keyboard is tracked, then the frame of this keyboard has non-zero height:  So to fix the problem with invalid keyboard view being found I decided to modify a condition and add additional condition to check that `frame.height != 0`. Follow up for #471 and #338 (comment) ## 馃摙 Changelog <!-- High level overview of important changes --> <!-- For example: fixed status bar manipulation; added new types declarations; --> <!-- If your changes don't affect one of platform/language below - then remove this platform/language --> ### iOS - ignore keyboard view if its `height == 0`; ## 馃 How Has This Been Tested? Tested on CI (e2e tests). ## 馃摑 Checklist - [x] CI successfully passed - [x] I added new mocks and corresponding unit-tests if library API was changed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
馃摐 Description
Handle corner case when keyboard view is not detectable on iOS.
馃挕 Motivation and Context
Sometimes app may have more than one
UITextEffectsWindowand nestedUIInputSetContainerViewmay not have a children (as on a screenshot):In this case our previous code would return
niland full library functionality would be broken. From a screenshot above it's clear, that we should continue our search.So to fix the problem I removed one
breaksignal (loop over windows). Thus if we encounter emptyUIInputSetContainerViewwe will continue search and will go to the next window (which will return a correct reference to the keyboard view).Additionally I added
returnstatement when we found a view (before 3 break statements served for this purpose, but since I removed one - the order is slightly broken, so to keep better backward compatibility and don't execute additional cycles if view was found - I usedreturnstatement there).See the context when we may have more than one
UITextEffectsWindowin #338 (comment)馃摙 Changelog
iOS
breakinside iteration over windowsreturnto exit fromforloops immediately馃 How Has This Been Tested?
Tested on iPhone 15 Pro (iOS 17.5).
馃摳 Screenshots (if appropriate):
Simulator.Screen.Recording.-.iPhone.15.Pro.-.2024-06-14.at.10.23.01.mp4
Simulator.Screen.Recording.-.iPhone.15.Pro.-.2024-06-14.at.10.22.09.mp4
馃摑 Checklist