[RNKC-051] - fabric support #64
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kirillzyusko
added
enhancement
…sending NaN as progress in onKeyboardMove)
kirillzyusko
commented
Sep 13, 2022
| } from 'react-native/Libraries/Types/CodegenTypes'; | ||
| import codegenNativeComponent from 'react-native/Libraries/Utilities/codegenNativeComponent'; | ||
|
|
||
| type KeyboardMoveEvent = Readonly<{ |
There was a problem hiding this comment.
I think similar data structure is already defined as NativeEvent in native.ts. Would it be possible to use one source of truth?
There was a problem hiding this comment.
Moving type declaration into separate file will cause an error during pods installation 🤷♂️
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added basic support for new (fabric) architecture.
Motivation and Context
The reason of prioritising a fabric adoption is an ability to perform sync communication between Native and JS thread. Especially it may become handy during the implementation of interactive keyboard on Android.
Current implementation allows to use both (old - paper, and new - fabric) architectures.
Unfortunately, it seems like Swift is not supported in new arch, so I had to rewrite some files to ObjC. I hope at some point of time we will bring it back to Swift.
Changelog
CI
cpplintas C++ codebase most likely will be increased over development iterations;JS
isFabricEnabledandisTurboModuleEnabledvariables;iOS
.mto.mmto support C++;Android
How Has This Been Tested?
Tested manually on:
Checklist