Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add highcharts-more dependency #3

Closed

Conversation

samuelmartineau
Copy link

Allows users to use gauges, ranges and polar

@kirjs
Copy link
Owner

kirjs commented Apr 21, 2015

Hi Samuel, Thanks for the PR.

One small thing here:
If we add it to index, then everybody using react-highcharts will get extra 25kb of code, even if they are not using highcharts-more.

I think in this case it would make sense to have a separate more.js file, so that users would be able to load it only when need it.

What do you think?

@samuelmartineau
Copy link
Author

I totally agree with you. I haven't looked at the size of highcharts-more and most people probably just need graph so you're right.

With your solution, people who want use highcharts-more just need to:

require('react-highcharts/index-more')

and it's still great

I am not familiar with webpack but if you haven't time to do that I can

@kirjs
Copy link
Owner

kirjs commented Apr 22, 2015

Up to you, if you want to experiment with webpack, go for it, otherwise I'll do it over the weekend.

@kirjs
Copy link
Owner

kirjs commented Apr 25, 2015

Hi Samuel,

I added highcharts-more support using require('react-highcharts/index-more')
I added a demo here.
And I added more instructions in the readme.

Let me know if it works for you.

@samuelmartineau
Copy link
Author

Hi,

It works perfectly on my project, thk.
Good job for the example and the doc.

@kirjs kirjs mentioned this pull request Jul 17, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants