Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle new session in log file appender #191

Merged
merged 3 commits into from
Dec 27, 2023
Merged

Handle new session in log file appender #191

merged 3 commits into from
Dec 27, 2023

Conversation

kirmanak
Copy link
Owner

This PR fixes three issues that appear when new session starts:

  1. The last lines of the previous session are not written to the file because they were buffered by the writer whose buffer was not filled.
  2. Hard to distinguish when new session starts as there are no marks.
  3. Preferences storage might log base URL before the base URL redactor is initialized.

@kirmanak kirmanak enabled auto-merge (squash) December 27, 2023 09:28
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Dec 27, 2023

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@kirmanak kirmanak merged commit ffdac4c into master Dec 27, 2023
4 checks passed
@kirmanak kirmanak deleted the logs branch December 27, 2023 09:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@kirmanak