Unflat json #62
Open
Unflat json #62
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kishor82
requested changes
Jun 8, 2024
| @@ -81,3 +81,37 @@ describe("flat functon", () => { | |||
| expect(flat(data)).toEqual(expected); | |||
| }); | |||
| }); | |||
|
|
|||
|
|
|||
| describe("unflat functon", () => { | |||
| }); | ||
|
|
||
| // Test case for unflattening a simple object | ||
| it("Unflattens a simple object", () => { |
| } else { | ||
| acc[k] = acc[k] || {}; | ||
| } | ||
| return acc[k]; |
Comment on lines
+23
to
+29
| keys.reduce((acc, k, i) => { | ||
| if (i === keys.length - 1) { | ||
| acc[k] = data[key]; | ||
| } else { | ||
| acc[k] = acc[k] || {}; | ||
| } | ||
| return acc[k]; |
There was a problem hiding this comment.
Please use meaningful argument/variables names.
| const unflat = (data, delimiter = ".") => { | ||
| return Object.keys(data).reduce((unflattenedObject, key) => { | ||
| const keys = key.split(delimiter); | ||
| keys.reduce((acc, k, i) => { |
There was a problem hiding this comment.
This reduce function is being used but its output isn't directly utilized. This approach is valid, but it can be a bit confusing. Using a simple forEach loop might make the intent clearer.
Comment on lines
+24
to
+28
| if (i === keys.length - 1) { | ||
| acc[k] = data[key]; | ||
| } else { | ||
| acc[k] = acc[k] || {}; | ||
| } |
There was a problem hiding this comment.
Please add a comment here to clarify the code's purpose.
| const expected = {}; | ||
| expect(unflat(data)).toEqual(expected); | ||
| }); | ||
| }) |
There was a problem hiding this comment.
Please add a few more tests that cover scenarios with more deeply nested objects, and also add module tests for cjs and esm.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related Issue
Add unflat Function to Restore Flattened JSON Structures #48
Checklist