fix for issues 34, 35 and 36 #38
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
34 pkgutil.get_loader().filename can be a directory 35 help finding out in which file PYTHON_ARGCOMPLETE_OK needs to be added --HG-- branch : tox_get_loader
| @@ -11,23 +11,41 @@ import os, sys, re, argparse, pkg_resources | |||
| parser = argparse.ArgumentParser(description=__doc__, | |||
| formatter_class=argparse.RawDescriptionHelpFormatter) | |||
|
|
|||
| parser.add_argument('--verbose', action='store_true') | |||
There was a problem hiding this comment.
Please do not introduce this option. Instead, like in the main body of the module, use the environment variable _ARC_DEBUG to see if debug output should be printed.
|
Thanks for the pkgutil fix! I'm ready to merge it once you fix the line comments, or please let me know if you want me to just put the one-liner in myself. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
solves issues:
34 pkgutil.get_loader().filename can be a directory
35 help finding out in which file PYTHON_ARGCOMPLETE_OK needs to be added
37 error while running python-argcomplete-check-easy-install-script on python 3.3