Note completers can return iterables of strings, not just lists #422
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some of the built in implementations actually do that already.
Codecov ReportPatch and project coverage have no change.
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more Additional details and impacted files@@ Coverage Diff @@
## develop #422 +/- ##
========================================
Coverage 81.29% 81.29%
========================================
Files 10 10
Lines 770 770
========================================
Hits 626 626
Misses 144 144 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
|
Thanks! And thanks for all your work on bash-completion. |
theacodes
pushed a commit
to wntrblm/nox
that referenced
this pull request
Feb 20, 2024
* feat: add envdir and report completions * feat: add python completions * feat: add tag completion * feat: add keywords non-completion This will actually only prevent completions with bash if the completion was registered using `register-python-argcomplete --complete-arguments -- nox` (i.e. with _all_ fallback completions disabled, not just the readline ones). But it does not hurt if registered without doing so. * refactor: return Iterables from completers kislyuk/argcomplete#422 * style: simplify completer functions Co-authored-by: Stanislav Filin <stasfilin@hotmail.com> * fix: return type hint for completer callables (`Iterable[str]`) kislyuk/argcomplete#422 * chore: appease mypy in completers code * test: add python and tag completer tests --------- Co-authored-by: Stanislav Filin <stasfilin@hotmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some of the built in implementations actually do that already.