Fix path to pexpect's bashrc #485
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix path to pexpect's bashrc, to make tests more reliable. The path was changed in 46e6e75 to `replwrap/bashrc.sh` inside pexpect package; however, FWICS no such directory ever existed and the bashrc file was always directly inside the package directory. Without this change, pexpect's bashrc is not loaded and tests fail when user's bashrc results in a long prompt. In my case, they failed on a system with a 12-character hostname (and passed on a system with a 6-character hostname).
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## develop #485 +/- ##
===========================================
+ Coverage 81.09% 81.21% +0.12%
===========================================
Files 10 10
Lines 788 788
===========================================
+ Hits 639 640 +1
+ Misses 149 148 -1 ☔ View full report in Codecov by Sentry. |
|
Thanks! |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix path to pexpect's bashrc, to make tests more reliable. The path was changed in 46e6e75 to
replwrap/bashrc.shinside pexpect package; however, FWICS no such directory ever existed and the bashrc file was always directly inside the package directory.Without this change, pexpect's bashrc is not loaded and tests fail when user's bashrc results in a long prompt. In my case, they failed on a system with a 12-character hostname (and passed on a system with a 6-character hostname).