Add _d param to indicate manual passing of a timestamp

[krizon]

Added the _d parameter for indicating the manual passing of a timestamp as described in the API Specifications.

[krizon]

@bhardin sorry to ping you but could you review this PR?

[bhardin]

Im away on vacation. @percyhanna can you review and merge?

—
Brett Hardin
http://bretthard.in

On Mon, Nov 17, 2014 at 11:55 PM, Kristian Zondervan
notifications@github.com wrote:

@bhardin sorry to ping you but could you review this PR?

Reply to this email directly or view it on GitHub:
#12 (comment)

[percyhanna]

The indentation on this block is inconsistent.

[percyhanna]

I think we should add some more tests to some of this, but otherwise it looks great. At a minimum we should add tests for null time values (right now the tests are passing in 0). I would also like to see more tests in KISSmetrics\Transport\Sockets, but I don't think that needs to be part of this PR (unless you want to add some). I'm thinking specific tests for the new behaviour of _d, as well as other tests for different end points of our tracking service.

[krizon]

I updated the PR. Fixed the indentation and provided extra Client tests covering the null value for time. I agree the transports need more tests but is out of scope for now. Thanks.

[percyhanna]

Awesome, thanks for the updates Kristian. This looks great.