Use Net::HTTP instead of TCPSocket for delivering request #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kissmetrics
pushed a commit
that referenced
this pull request
Jun 7, 2011
Use Net::HTTP instead of TCPSocket for delivering request
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
I'm using the km gem in an application for delivering events that occur outside of the end-user request/response cycle like monthly billing. I want to integration test this using Webmock, which relies on the HTTP request being delivered with an HTTP library (Net::HTTP, Patron, Curb, etc.).
This commit changes the KM class to deliver events with Net::HTTP instead of TCPSocket. The test suite still passes, and there should be no change to the publicly exposed API. Would you consider including this and issuing a gem release?
Thanks,
Jason