-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Provided docstrings for client.py
#11
Conversation
|
||
:param trk_host: tracking URL for all requests; defaults | ||
production tracking service. | ||
:param trk_proto: the protocol for requests; either be HTTP or |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
accepted values are http
or https
@@ -6,9 +6,23 @@ | |||
|
|||
|
|||
class Client: | |||
"""Provides an interface to KISSmetrics tracking service.""" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Alright, time to get anal! :) But only because Andy asked me to.
I like to document my classes as noun phrases -- objects are the nouns of programming after all -- and save the verbs for my methods and functions. This has the added benefit of cutting down on verbosity. Thus I'd suggest we simplify this to "Interface to the KISSmetrics tracking service" or something similar.
i like where this is going. keep kicking ass dudez |
@@ -1,10 +1,22 @@ | |||
# -*- coding: utf-8 -*- | |||
|
|||
#: Current URI for all Tracking service endpoints. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Default host for tracking service endpoint
so @lenards you can feel happy to fix our naming conventions within client.py on this PR per the following helpful ascii diagram:
or i'll come through in one PR and get us lined up |
I merged master into my PR to get the "remove QueryString class" and all the goodness from bcurtin |
I'll get this PR in-line with all the activity once the dust settles. |
Now it's ready (spoke too soon) |
This is looking really good. My final nits are to do a quick s/$/./ on client_compat.py lines 48 and 134, and on query_string.py line 19 (since those are verb phrases). Other than that this gets a 👍 from me after Travis assures me it's all okay. |
@lenards can you add an empty new line to all docstrings that need them? |
1 similar comment
Provided docstrings for ``client.py``
Relates to #5
These docstrings are provided with Sphinx-style
info field list
formatting. The intended target of the documentation from the docstrings is "readthedocs" and it uses Sphinx.The voice/tone of the documentation may not be satisfactory so only this file has been done to seek feedback.