Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add LEDs to footprints #23

Open
perigoso opened this issue Dec 24, 2021 · 3 comments
Open

Add LEDs to footprints #23

perigoso opened this issue Dec 24, 2021 · 3 comments
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed

Comments

@perigoso
Copy link
Collaborator

maybe a led symbol within a square that shows the location

some footprints already had marking that were removed in the process of being scripted like the ones in #11 #12

@perigoso perigoso added enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed labels Dec 24, 2021
@AlmogShKt
Copy link

hey!
I would like to help you with this issue.
this is my first time contributing.
can you explain more about the issue? where do you want to add the led locations?

@perigoso
Copy link
Collaborator Author

perigoso commented Dec 24, 2021

I want to add some sort of marking in the User.Drawings like the keycaps are, the point is for the user to know where to add the LEDs for the switches, i was thinking a rectangle representing the area available for the leds, with maybe a center marker and and led symbol to make it clear to end user

To implement i was thinking of making a Node class like did with the keycaps, the constructor would take in the size of the area and it's center location, and the switch classes would import that directly and append to self

Honestly the most work will be gathering the location and size info of the led location for each switch, and if it exists in the first place

@perigoso perigoso changed the title Add led locations ~~Add led locations~~ Add LEDs to footprints May 26, 2022
@perigoso perigoso changed the title ~~Add led locations~~ Add LEDs to footprints Add LEDs to footprints May 26, 2022
@perigoso
Copy link
Collaborator Author

perigoso commented May 26, 2022

I changed my mind on how I want this to work, I want to have the LEDs embedded in the footprint, behaving like the keycaps do right now in the scripts, they wont be included in the default library but will be generate-able now manually, and later through the TODO plugin
This comes with a couple problems to solve, the positioning needs to be handled somehow in the switch class, presumably after the Led class has been created
And the hardest I think is handling the Library symbols, perhaps for now we could have a couple fixed options, essentially one for each LED, but at some point automatic generation and assignment should be considered

from #40

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Development

No branches or pull requests

2 participants