Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change how keycaps are handled #49

Open
perigoso opened this issue May 26, 2022 · 0 comments
Open

Change how keycaps are handled #49

perigoso opened this issue May 26, 2022 · 0 comments
Labels
enhancement New feature or request scripts Related to generation scripts

Comments

@perigoso
Copy link
Collaborator

Right now we create a class instance of a keycap, and pass it to the switch initializer

I propose we change the behaviour to passing the class only, and the the class instance will be initialized inside the switch, we pass the keycap args as **kwargs, and the switch essentially passes every kwarg into the keycap initializer

this is to accommodate the addition of LEDs to the switches, see #23 , this also makes sense to handle stabilizers if we ever do in the switch

we could make the passing of these classes a list, the switch would initialize them one by one and append them without caring what they are

@perigoso perigoso added enhancement New feature or request scripts Related to generation scripts labels May 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request scripts Related to generation scripts
Development

No branches or pull requests

1 participant