Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ineffectual assignments in Go code (https://goreportcard.com/report/github.com/kitabisa/moco) #2

Closed
dhiemaz opened this issue Dec 9, 2019 · 1 comment
Closed

ineffectual assignments in Go code (https://goreportcard.com/report/github.com/kitabisa/moco) #2

dhiemaz opened this issue Dec 9, 2019 · 1 comment
Assignees
@pushm0v

Comments

@dhiemaz
Copy link

dhiemaz commented Dec 9, 2019

moco/trimmer.go

Line 17 in a0895d9

var found = false

can use declaration without assignment, the zero value for boolean datatype will be false.
var found bool // <-- use zero value for boolean datatype which is false
@pushm0v pushm0v mentioned this issue Dec 11, 2019
Merged
pushm0v added a commit that referenced this issue Dec 11, 2019
@pushm0v
Merge pull request #3 from pushm0v/master
3668d88 
Enhance trimmer on issue #1 & #2
@pushm0v pushm0v self-assigned this Dec 11, 2019
@pushm0v
Copy link
Contributor

pushm0v commented Dec 11, 2019

Solved in #3

@pushm0v pushm0v closed this as completed Dec 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pushm0v pushm0v

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@pushm0v @dhiemaz