Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add batch write item #25

Closed
wants to merge 8 commits into from
Closed

Add batch write item #25

wants to merge 8 commits into from

Conversation

negoziator
Copy link
Contributor

---> DRAFT PULL REQUEST <---

Description

Starting to work on a implentation for batch writing items.
This is to gain a lot of performance when inserting many items.

Let's see if this can be done in a clean way.

Please feel free to join in 😄

Notes:

  • BatchWriteItem only supports insert of 25 items at a time - so probably something needs to check that.
  • BatchWriteItem does not support updates
  • The model layer don't understand "saveMany" in one go, so the query builder has to implement it.

Documentation
https://docs.aws.amazon.com/amazondynamodb/latest/APIReference/API_BatchWriteItem.html

@kitar
Copy link
Owner

kitar commented Sep 22, 2022

Looks amazing! Thank you for start working on this. I’ll try your code as well.

@negoziator
Copy link
Contributor Author

Thanks @kitar !

I'll try it out in a real project in the coming days.

@negoziator
Copy link
Contributor Author

Still not forgotten. I'm just testing it out on our own systems. It will take some time unfortunately - and i'm going on a week's vacation now :)

However .. i think it would be nice to also implement BatchGetItem as well .

@kitar
Copy link
Owner

kitar commented Oct 3, 2022

@negoziator No need to rush! Enjoy your vacation and take it at a comfortable pace :) (BTW, I won't have enough time at this time either😅)

@negoziator
Copy link
Contributor Author

@kitar I will have to abandon this PR - as i can't make it work in a nice way with the QueryBuilder class.

@negoziator negoziator closed this Dec 12, 2022
@kitar
Copy link
Owner

kitar commented Dec 12, 2022

@negoziator No problem! Thank you for letting me know and for your suggestion. It was helpful for future development :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants