fix Logo alt-Title + add German translations #337
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davisagli
requested changes
Feb 1, 2024
There was a problem hiding this comment.
Based on the discussion in plone/volto#5722, this should either say "Visit home page" or use the title of the site.
|
See discussion on the reopened issue for a single place to discuss how to proceed for this issue. |
|
@Molochem needs to be adjusted, right? |
|
@Molochem please update it with the latests developments in Volto. |
|
@jonaspiterek could you please take over? |
sneridagh
approved these changes
Jun 3, 2024
davisagli
reviewed
Jun 3, 2024
| alt={intl.formatMessage(messages.plonesite)} | ||
| title={intl.formatMessage(messages.plonesite)} | ||
| alt={intl.formatMessage(messages.homepage)} | ||
| title={intl.formatMessage(messages.homepage)} |
There was a problem hiding this comment.
@sneridagh @Molochem This approach is not correct based on the discussion in plone/volto#5720 (comment)
- Neither the link nor the img should have
title - The link should have
aria-label="Home" - The img should have
alt="Logo"
sneridagh
added a commit
that referenced
this pull request
Jul 2, 2024
* main: (25 commits) Upgrade to a39, enable new image widget (#405) Finish interrupted push Fixes #400, install in Volto 17 Fix Invalid html structure in caption component (#401) build deps Upgrade to Volto a37 (#403) Release 4.0.0 Fix release-it script Changelog Fix tabbing in header (reapplies #346 as breaking) (#374) Customizable mobile navigation (#393) Fix Description block width in Edit/Add (#394) Slight improvements Adjust height Add BMv3 ready logo Remove not needed dockerfiles folder Update setup. Use new images. (#390) fix Logo alt-Title + add German translations (#337) fix link in introduction block being smaller than normal text (#366) Release 3.3.2 ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #336
Fixed the Logo-Alt Title to display "Back to homepage", added fitting Translations. Also added a Lot of missing German Translations to
locales/de/LC_MESSAGES/volto.poi noticed.