Make Volto requirements more explicit. #400
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@fredvd I don't think that we did nothing breaking that would make 4.x not work with Volto 17. |
|
I tried it in a 17 project by pinning 4.0.0 and it fails. Iirc something with not finding ‘@plone/components’. That’s why I started looking for more info. I can give you the exact error if you want to see it. |
|
@fredvd uh, I see the problem now... I will fix it. |
|
@fredvd now should be fine, can you test it using 4.0.1? |
|
@fredvd I added this https://github.com/kitconcept/volto-light-theme/pull/405/files#diff-b335630551682c19a781afebcf4d07bf978fb1f8ac04c6bf87428ed5106870f5R235 to the other PR, that will supersed this one. |
sneridagh
added a commit
that referenced
this pull request
Jul 2, 2024
* main: (25 commits) Upgrade to a39, enable new image widget (#405) Finish interrupted push Fixes #400, install in Volto 17 Fix Invalid html structure in caption component (#401) build deps Upgrade to Volto a37 (#403) Release 4.0.0 Fix release-it script Changelog Fix tabbing in header (reapplies #346 as breaking) (#374) Customizable mobile navigation (#393) Fix Description block width in Edit/Add (#394) Slight improvements Adjust height Add BMv3 ready logo Remove not needed dockerfiles folder Update setup. Use new images. (#390) fix Logo alt-Title + add German translations (#337) fix link in introduction block being smaller than normal text (#366) Release 3.3.2 ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.