Feature add methods to bridge dubbo-hessian2 and kitex-hessian #33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lvnszn
force-pushed
the
feature_hessian_wrap
branch
from
49caaf3
to
6eefc96
Compare
felix021
reviewed
Aug 19, 2023
felix021
reviewed
Aug 20, 2023
| type TestServiceEchoIntArgs struct { | ||
| Req int32 `json:"req"` | ||
| } | ||
| func (p *EchoRequest) Encode(e codec.Encoder) error { |
There was a problem hiding this comment.
The Encode and Decode functions are not used?
felix021
reviewed
Aug 20, 2023
|
|
||
| func init() { | ||
| hessian.RegisterPOJO(&EchoRequest{}) | ||
| hessian.RegisterPOJO(&EchoResponse{}) | ||
| register(objects) |
There was a problem hiding this comment.
这里可以直接调用 hessian2.Register，不用 register 函数了
felix021
approved these changes
Aug 20, 2023
felix021
reviewed
Aug 20, 2023
| } | ||
| svcInfo := &kitex.ServiceInfo{ | ||
| ServiceName: serviceName, | ||
| HandlerType: handlerType, | ||
| Methods: methods, | ||
| KiteXGenVersion: "v0.6.1", | ||
| PayloadCodec: kitex.Thrift, |
jasondeng1997
approved these changes
Aug 21, 2023
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: felix021, jasondeng1997, Lvnszn The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
LGTM |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
add methods to bridge dubbo-hessian2 and kitex-hessian
Check the PR title.
(Optional) Translate the PR title into Chinese.
(Optional) More detailed description for this PR(en: English/zh: Chinese).
en:
zh(optional):
(Optional) Which issue(s) this PR fixes:
(optional) The PR that updates user documentation: