Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Compatible with int8 && int16, update test cases #58

Merged
merged 4 commits into from
Nov 2, 2023

Conversation

ahaostudy
Copy link
Collaborator

What type of PR is this?

test

Check the PR title.

  • This PR title match the format: <type>(optional scope): <description>
  • The description of this PR title is user-oriented and clear enough for others to understand.
  • Attach the PR updating the user documentation if the current PR requires user awareness at the usage level. User docs repo

(Optional) Translate the PR title into Chinese.

(Optional) More detailed description for this PR(en: English/zh: Chinese).

en:
zh(optional):

(Optional) Which issue(s) this PR fixes:

(optional) The PR that updates user documentation:

Copy link
Collaborator

@DMwangnima DMwangnima left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

EchoMultiByte and EchoMultiInt16 in dubbo2kitex could work well for now? If these two cases work, please modify documents in Type Mapping part to tell users that they can pass List or Map of i8 and i16 types embedded in struct.

README.md Outdated Show resolved Hide resolved
tests/crosstest/go.mod Outdated Show resolved Hide resolved
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: ahaostudy, felix021
To complete the pull request process, please assign jasondeng1997 after the PR has been reviewed.
You can assign the PR to them by writing /assign @jasondeng1997 in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@DMwangnima DMwangnima merged commit 6e1b3bd into kitex-contrib:main Nov 2, 2023
10 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants