Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: complete the extension #2

Merged
merged 27 commits into from
Nov 26, 2023
Merged

fix: complete the extension #2

merged 27 commits into from
Nov 26, 2023

Conversation

XZ0730
Copy link
Member

@XZ0730 XZ0730 commented Oct 4, 2023

What type of PR is this?

Check the PR title.

  • This PR title match the format: <type>(optional scope): <description>
  • The description of this PR title is user-oriented and clear enough for others to understand.
  • Attach the PR updating the user documentation if the current PR requires user awareness at the usage level. User docs repo

(Optional) Translate the PR title into Chinese.

(Optional) More detailed description for this PR(en: English/zh: Chinese).

en:
zh(optional):

(Optional) Which issue(s) this PR fixes:

(optional) The PR that updates user documentation:

@XZ0730
Copy link
Member Author

XZ0730 commented Oct 4, 2023

fix: √ 1. avoid panic when code start
√ 2. goroutine recover
√ 3. delete change listen (maybe can be some method to optimize)
√ 4. retryContainer init
√ 5. code style
- 6. README.md
√ 7. issue doc

@ppzqh
Copy link

ppzqh commented Oct 11, 2023

@felix021 这个帮忙review一下呢

apollo/apollo.go Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
apollo/apollo.go Show resolved Hide resolved
apollo/apollo.go Outdated Show resolved Hide resolved
apollo/apollo.go Outdated Show resolved Hide resolved
@li-jin-gou
Copy link
Contributor

参考 kitex-contrib/config-nacos#17 完善一下 readme 和 example

@li-jin-gou
Copy link
Contributor

参考 https://github.com/kitex-contrib/config-nacos/tree/main/licenses 补充 go.mod 直接依赖的 license

README.md Show resolved Hide resolved
README.md Show resolved Hide resolved
README.md Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README_CN.md Show resolved Hide resolved
README_CN.md Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
apollo/apollo.go Outdated Show resolved Hide resolved
apollo/apollo.go Outdated Show resolved Hide resolved
client/retry.go Outdated Show resolved Hide resolved
client/rpc_timetout.go Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README_CN.md Outdated Show resolved Hide resolved
client/circurit_breaker.go Show resolved Hide resolved
.agollo Outdated Show resolved Hide resolved
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: li-jin-gou, ViolaPioggia, XZ0730

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@li-jin-gou li-jin-gou merged commit 78acd2f into kitex-contrib:main Nov 26, 2023
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants