docs:add README.md #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
whalecold
reviewed
Nov 20, 2023
felix021
reviewed
Nov 20, 2023
felix021
reviewed
Nov 20, 2023
whalecold
reviewed
Nov 20, 2023
|
/lgtm |
li-jin-gou
requested changes
Nov 20, 2023
| [中文](./README_CN.md) | ||
|
|
||
| etcd as config center for service governance. |
There was a problem hiding this comment.
参考 https://github.com/hertz-contrib/registry/tree/main/licenses 补充一下直接依赖的 license
config-nacos 辛苦有时间也补充一下 @whalecold
|
重新 format 一下 import 的格式吧 https://github.com/ViolaPioggia/config-etcd/blob/config-etcd/etcd/etcd.go#L25 && 不只这一处 |
|
New changes are detected. LGTM label has been removed. |
li-jin-gou
approved these changes
Nov 20, 2023
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: li-jin-gou, ViolaPioggia The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
docs
Check the PR title.
docs:add README.md
(Optional) Translate the PR title into Chinese.
增加了 README 文档
(Optional) Which issue(s) this PR fixes:
Fixes cloudwego/kitex#1140