feat(limiter): implement the limiter config #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
license-eye has totally checked 34 files.
| Valid | Invalid | Ignored | Fixed |
|---|---|---|---|
| 14 | 1 | 19 | 0 |
Click to see the invalid file list
- server/limiter.go
felix021
reviewed
Aug 14, 2023
felix021
reviewed
Aug 14, 2023
felix021
reviewed
Aug 14, 2023
whalecold
force-pushed
the
feat/limiter
branch
from
a76d265
to
c190c03
Compare
felix021
reviewed
Aug 14, 2023
felix021
reviewed
Aug 14, 2023
felix021
reviewed
Aug 14, 2023
server/suit.go
Outdated
| ) | ||
|
|
||
| const ( | ||
| limiterConfigName = "limiter_config" |
There was a problem hiding this comment.
The config names can be simplified (like limit, retry, ...), no need to be the same as Bytedance internal (I was expecting this project to use configmanager when writing the proposal).
jayantxie
reviewed
Aug 15, 2023
felix021
approved these changes
Aug 25, 2023
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: felix021, whalecold The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Check the PR title.
(Optional) Translate the PR title into Chinese.
(Optional) More detailed description for this PR(en: English/zh: Chinese).
en:
zh(optional):
(Optional) Which issue(s) this PR fixes:
cloudwego/kitex#975
(optional) The PR that updates user documentation: