Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

recordStackTraceInSpan param do not use #4

Closed
zstone12 opened this issue Jun 13, 2022 · 2 comments
Closed

recordStackTraceInSpan param do not use #4

zstone12 opened this issue Jun 13, 2022 · 2 comments

Comments

@zstone12
Copy link
Contributor

zstone12 commented Jun 13, 2022

logging/logrus/option.go
func WithRecordStackTraceInSpan(recordStackTraceInSpan bool) Option { return option(func(cfg *config) { cfg.traceHookConfig.recordStackTraceInSpan = true }) }

@zstone12
Copy link
Contributor Author

zstone12 commented Jun 13, 2022

I think remove the param or use it cfg.traceHookConfig.recordStackTraceInSpan = recordStackTraceInSpan

@CoderPoet
Copy link
Member

I think remove the param or use it cfg.traceHookConfig.recordStackTraceInSpan = recordStackTraceInSpan

Thanks for the reminder, there is indeed a problem, thanks for your PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants