Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: option param #5

Merged
merged 2 commits into from
Jun 16, 2022
Merged

fix: option param #5

merged 2 commits into from
Jun 16, 2022

Conversation

zstone12
Copy link
Contributor

@zstone12 zstone12 commented Jun 13, 2022 •
edited

About #4

@CLAassistant
Copy link

CLAassistant commented Jun 13, 2022 •
edited

CLA assistant check
All committers have signed the CLA.

CoderPoet
CoderPoet reviewed Jun 16, 2022
View reviewed changes
logging/logrus/option.go Outdated Show resolved Hide resolved
@CoderPoet
Copy link
Member

/lgtm

@bytedance-oss-robot bytedance-oss-robot bot added the lgtm Indicates that a PR is ready to be merged. label Jun 16, 2022
@CoderPoet
Copy link
Member

CLA assistant check Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

@zstone12 You may need SLA

@zstone12 zstone12 closed this Jun 16, 2022
@zstone12 zstone12 reopened this Jun 16, 2022
@bytedance-oss-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: zstone12
To complete the pull request process, please ask for approval from coderpoet after the PR has been reviewed.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@zstone12
Copy link
Contributor Author

CLA assistant check Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

@zstone12 You may need SLA

done.

@CoderPoet CoderPoet merged commit 3751803 into kitex-contrib:main Jun 16, 2022
@CoderPoet
Copy link
Member

Merged, thank you very much for your PR !

@zstone12 zstone12 mentioned this pull request Nov 23, 2022
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CoderPoet CoderPoet CoderPoet left review comments

Assignees

@CoderPoet CoderPoet

Labels
lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@zstone12 @CLAassistant @CoderPoet