Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement OpenTelemetry integration #1

Merged
merged 41 commits into from
Mar 23, 2022
Merged

Implement OpenTelemetry integration #1

merged 41 commits into from
Mar 23, 2022

Conversation

CoderPoet
Copy link
Member

@CoderPoet CoderPoet commented Mar 8, 2022 •
edited

Provider

  • Out-of-the-box default opentelemetry provider

Instrumentation

Tracing

  • Support server and client kitex rpc tracing
  • Support automatic transparent peer service by metaInfo

Metrics

  • Support kitex rpc metrics [RED]
  • Support peer service dimension in rpc metrics, which can be used to build topology graph
  • Support go runtime metrics

Logging

  • Extend kitex logger based on logrus
  • Implement tracing auto associated logs

@CoderPoet CoderPoet changed the title Implement Opentelemetry integration Implement OpenTelemetry integration Mar 8, 2022
@GuangmingLuo GuangmingLuo requested review from GuangmingLuo and simon0-o and removed request for GuangmingLuo and simon0-o March 9, 2022 02:30
@simon0-o simon0-o self-assigned this Mar 9, 2022
simon0-o
simon0-o suggested changes Mar 10, 2022
View reviewed changes
logging/kitexlogrus/go.mod Outdated Show resolved Hide resolved
logging/kitexlogrus/logger.go Outdated Show resolved Hide resolved
@CLAassistant
Copy link

CLAassistant commented Mar 10, 2022 •
edited

CLA assistant check
All committers have signed the CLA.

simon0-o
simon0-o suggested changes Mar 16, 2022
View reviewed changes
README.md Outdated Show resolved Hide resolved
logging/logrus/logger_test.go Outdated Show resolved Hide resolved
tracing/middleware.go Outdated Show resolved Hide resolved
tracing/options.go Show resolved Hide resolved
tracing/semconv.go Outdated Show resolved Hide resolved
tracing/suite.go Show resolved Hide resolved
github-actions[bot]
github-actions bot reviewed Mar 16, 2022
View reviewed changes
tracing/middleware.go Outdated Show resolved Hide resolved
coderYPG
coderYPG suggested changes Mar 17, 2022
View reviewed changes
tracing/tracer_server.go Show resolved Hide resolved
@GuangmingLuo GuangmingLuo removed their request for review March 17, 2022 10:52
YangruiEmma
YangruiEmma reviewed Mar 20, 2022
View reviewed changes
tracing/utils.go Outdated Show resolved Hide resolved
YangruiEmma
YangruiEmma reviewed Mar 20, 2022
View reviewed changes
tracing/middleware.go Outdated Show resolved Hide resolved
@lsjbd lsjbd self-requested a review March 22, 2022 03:03
@YangruiEmma
Copy link
Contributor

/approve

@YangruiEmma YangruiEmma merged commit 353a6ad into main Mar 23, 2022
@CoderPoet CoderPoet mentioned this pull request Mar 25, 2022
Closed
3 tasks
@GuangmingLuo GuangmingLuo deleted the feature/opentelemetry branch June 6, 2022 02:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions left review comments

@li-jin-gou li-jin-gou li-jin-gou left review comments

@simon0-o simon0-o simon0-o requested changes

@YangruiEmma YangruiEmma YangruiEmma approved these changes

@coderYPG coderYPG coderYPG approved these changes

@lsjbd lsjbd lsjbd approved these changes

Assignees

@simon0-o simon0-o

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@CoderPoet @CLAassistant @YangruiEmma @simon0-o @coderYPG @lsjbd @li-jin-gou