Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(logging/zap): log extrakeys #26

Merged
merged 1 commit into from
Nov 3, 2023
Merged

feat(logging/zap): log extrakeys #26

merged 1 commit into from
Nov 3, 2023

Conversation

rogerogers
Copy link
Collaborator

No description provided.

@bytedance-oss-robot bytedance-oss-robot bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 15, 2023
@rogerogers rogerogers marked this pull request as draft August 15, 2023 07:27
@rogerogers rogerogers force-pushed the feat/extrakey branch 2 times, most recently from 207badc to 095706e Compare October 28, 2023 06:25
@rogerogers
feat(logging/zap): log extrakeys
db47668 
Signed-off-by: rogerogers <rogers@rogerogers.com>
@rogerogers rogerogers marked this pull request as ready for review October 31, 2023 09:20
@rogerogers rogerogers changed the title [WIP] feat(logging/zap): log extrakeys feat(logging/zap): log extrakeys Oct 31, 2023
@bytedance-oss-robot bytedance-oss-robot bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 31, 2023
@bytedance-oss-robot bytedance-oss-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: li-jin-gou, rogerogers
To complete the pull request process, please assign coderpoet after the PR has been reviewed.
You can assign the PR to them by writing /assign @coderpoet in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@li-jin-gou li-jin-gou merged commit 6f0423a into kitex-contrib:main Nov 3, 2023
7 of 8 checks passed
@rogerogers rogerogers deleted the feat/extrakey branch November 9, 2023 14:53
@rogerogers rogerogers mentioned this pull request Nov 9, 2023
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@li-jin-gou li-jin-gou li-jin-gou approved these changes

@CoderPoet CoderPoet Awaiting requested review from CoderPoet

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@rogerogers @li-jin-gou