Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix:fix logrus cancel trace info #33

Merged
merged 1 commit into from
Nov 24, 2023

Conversation

ViolaPioggia
Copy link
Contributor

fix:fix logrus cancel trace info

修复了 logrus ctx 中无 trace 信息却打印出了空值的问题

以下是前后对比

image

Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: ViolaPioggia
To complete the pull request process, please assign coderpoet after the PR has been reviewed.
You can assign the PR to them by writing /assign @coderpoet in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ViolaPioggia ViolaPioggia changed the base branch from fix/logrus to main November 24, 2023 13:23
@li-jin-gou li-jin-gou merged commit 122aaec into kitex-contrib:main Nov 24, 2023
7 of 8 checks passed
@CoderPoet
Copy link
Member

@ViolaPioggia @li-jin-gou 有一个更合适的修复方案哈: #39

nonRecord 的 span,只是表示这个 span 不可变了,并非是取不到 span context 的
noopSpan 才是取不到 span context 的

88i7SNC9Uo

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants