Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

git action #3

Merged
merged 1 commit into from
Jan 10, 2022
Merged

git action #3

merged 1 commit into from
Jan 10, 2022

Conversation

baiyutang
Copy link
Contributor

  1. add git action config.
  2. remove example dir,the code writed in kitex-examples is better.
  3. update copyright.

@bytedance-oss-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: baiyutang
To complete the pull request process, please assign duduainankai after the PR has been reviewed.
You can assign the PR to them by writing /assign @duduainankai in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@lizhemingi
Copy link
Collaborator

Thank you for your contribution.

I think keep the example would be better, since we can easily find a usage example in the current repo and run when cloned instead of going to another one.

@lizhemingi
Copy link
Collaborator

It would be very nice if you can squash the commits after you finished the code. @baiyutang

@baiyutang
Copy link
Contributor Author

It would be very nice if you can squash the commits after you finished the code. @baiyutang

done

@GuangmingLuo
Copy link
Member

GuangmingLuo commented Jan 10, 2022

  1. add git action config.
  2. remove example dir,the code writed in kitex-examples is better.
  3. update copyright.

you may update your pr description.

@GuangmingLuo GuangmingLuo merged commit b1c9497 into kitex-contrib:main Jan 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants