Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat:add registry eureka #3

Merged
merged 2 commits into from
Jan 20, 2022
Merged

feat:add registry eureka #3

merged 2 commits into from
Jan 20, 2022

Conversation

li-jin-gou
Copy link
Contributor

添加 eureka 的服务发现与注册插件.
eureka的客户端使用的是 fargo

@simon0-o
Copy link
Member

我注意到 fargo 使用了 github.com/op/go-logging 这个日志库，且 fargo 没有提供调整日志库的接口。
我们最好能在 README 里提供下更改日志输出等级的方法，不然用户可能得去查找 fargo 源码才能找到解决办法。

simon0-o
simon0-o reviewed Jan 19, 2022
View reviewed changes
resolver/resolver.go Outdated Show resolved Hide resolved
resolver/resolver.go Outdated Show resolved Hide resolved
registry/registry.go Outdated Show resolved Hide resolved
registry/registry.go Outdated Show resolved Hide resolved
@li-jin-gou
Copy link
Contributor Author

我注意到 fargo 使用了 github.com/op/go-logging 这个日志库，且 fargo 没有提供调整日志库的接口。 我们最好能在 README 里提供下更改日志输出等级的方法，不然用户可能得去查找 fargo 源码才能找到解决办法。

已加.

simon0-o
simon0-o approved these changes Jan 20, 2022
View reviewed changes
Copy link
Member

@simon0-o simon0-o left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

感谢贡献！

@simon0-o simon0-o merged commit af7df29 into kitex-contrib:main Jan 20, 2022
@li-jin-gou li-jin-gou mentioned this pull request Feb 23, 2022
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@simon0-o simon0-o simon0-o approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@li-jin-gou @simon0-o